shaunrd0
23c9125ad8
Backend CI / Lint (push) Waiting to run
Backend CI / Tests (push) Waiting to run
Squashes 26 incremental fork commits (Apr–May 2026) onto upstream main as a single
diff for cleaner cross-fork comparison. Original history preserved on the
pre-squash-backup tag locally.
Feature additions
─────────────────
• Inline single-track download via yt-dlp-worker proxy
New routes: POST /api/v1/track-download/search (source: youtube | spotify),
POST /api/v1/track-download, GET /api/v1/track-download/{id}. Frontend
TrackDownloadButton in album track list AND popular-songs row, with a per-button
source picker. Per-user rate limits live in the worker's SQLite store. On
completion the backend fires Lidarr RefreshArtist + Plex library refresh +
cache invalidation, and the popular-songs list auto-refreshes.
• Per-instance library pinning via MUSICSEERR_LIBRARY env
Backend stamps the library label server-side (music / music-personal /
music-shared); clients cannot override. Drives an instance-segregated
deployment of three musicseerr containers sharing one source tree.
• Lidarr-request flow (single-track requests via Lidarr indexers)
New routes: POST /api/v1/lidarr-request, GET /api/v1/lidarr-request/status.
Per-album asyncio.Lock keyed on album_mbid so rapid-clicks on the same album
serialize correctly. Cross-release track matcher with foreignTrackId →
foreignRecordingId → position+disc → exact-title → substring fallback chain,
evaluated per release (recording UUIDs frequently differ between album,
single, and deluxe edition releases of the same song). Flips
artist.monitored = True on request so Lidarr's WantedAlbums query reaches
the track. Full Lidarr-chain gate (artist AND album AND track) for the
status endpoint to avoid false-positive REQUESTED display. Persistent UI
state so button icons survive refresh and cross-album navigation.
• Privacy: show_now_playing toggle in Settings → Home
Default off. Plex /status/sessions returns active audio sessions across the
whole server with no library-section filter, so a shared instance leaks
every household member's listening activity. The merged store still emits
the user's local MusicSeerr playback bar; only server-derived sessions
(Plex / Jellyfin / Navidrome) are gated.
• Per-button visibility prefs for the track-row action cluster
Settings → Preferences → Download Options / Playback Buttons. Per-context
(popular_songs / album_page) force-off flags layered on top of the existing
source-availability gate.
• UX: wrap action cluster on mobile, hide LidarrRequestButton in tight
layouts, cross-album status-leak fix in AlbumTrackList ($effect keyed on
album.musicbrainz_id to rebuild lookup; map keyed by
"{albumMbid}:{position}:{disc}").
Test coverage
─────────────
Backend pytest: full suite green (2031/2031 as of squash). New: schema-default
tests for HomeSettings, lidarr_request_service cross-release matcher
regression test, singleton-registry expected-count bump to 59. Frontend
vitest: SettingsHome.svelte.spec covers new toggle, nowPlayingSessions
.svelte.spec covers the privacy gate (no fetch when off; fetches when on).
61 lines
2.0 KiB
Python
61 lines
2.0 KiB
Python
"""Inline track-download API. Fork-only addition.
|
|
|
|
Proxies to the yt-dlp-worker sidecar on gnat. The library label is fixed by
|
|
backend env (MUSICSEERR_LIBRARY) — clients cannot override it.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from fastapi import APIRouter, Depends
|
|
|
|
from api.v1.schemas.track_download import (
|
|
TrackDownloadAccepted,
|
|
TrackDownloadJobStatus,
|
|
TrackDownloadRequest,
|
|
TrackDownloadSearchRequest,
|
|
TrackDownloadSearchResponse,
|
|
)
|
|
from core.dependencies import get_track_download_service
|
|
from infrastructure.msgspec_fastapi import MsgSpecBody, MsgSpecRoute
|
|
from services.track_download_service import TrackDownloadService
|
|
|
|
router = APIRouter(
|
|
route_class=MsgSpecRoute,
|
|
prefix="/track-download",
|
|
tags=["track-download"],
|
|
)
|
|
|
|
|
|
@router.post("/search", response_model=TrackDownloadSearchResponse)
|
|
async def search_candidates(
|
|
body: TrackDownloadSearchRequest = MsgSpecBody(TrackDownloadSearchRequest),
|
|
service: TrackDownloadService = Depends(get_track_download_service),
|
|
) -> TrackDownloadSearchResponse:
|
|
return await service.search(query=body.query, limit=body.limit, source=body.source)
|
|
|
|
|
|
@router.post("", response_model=TrackDownloadAccepted, status_code=202)
|
|
async def request_track_download(
|
|
body: TrackDownloadRequest = MsgSpecBody(TrackDownloadRequest),
|
|
service: TrackDownloadService = Depends(get_track_download_service),
|
|
) -> TrackDownloadAccepted:
|
|
return await service.request_download(
|
|
video_id=body.video_id,
|
|
source=body.source,
|
|
target_duration_seconds=body.target_duration_seconds,
|
|
artist=body.artist,
|
|
album=body.album,
|
|
track_title=body.track_title,
|
|
artist_mbid=body.artist_mbid,
|
|
track_position=body.track_position,
|
|
disc_number=body.disc_number,
|
|
)
|
|
|
|
|
|
@router.get("/{job_id}", response_model=TrackDownloadJobStatus)
|
|
async def get_track_download_job(
|
|
job_id: str,
|
|
service: TrackDownloadService = Depends(get_track_download_service),
|
|
) -> TrackDownloadJobStatus:
|
|
return await service.get_job(job_id)
|